T09 · Insecure Skill Coding Practices
- Location
push.js:81- Finding
Unrestricted Recursive Upload and Symbolic-Link Traversal Can Disclose Local Files
- Content
View full analysis
- Remediation
View remediation
Security audit
Security checks for vulnerabilities and agentic risk
This skill is a real ClawHub publishing helper, but it can upload more local files than users may expect and uses stored credentials for remote publication without enough safeguards.
Review this skill before installing. Use it only on clean skill directories that contain no secrets, .env files, private keys, local configs, or symlinks, and be aware it will use your local ClawHub token to publish to clawhub.ai while automatically accepting license terms. Prefer a version with dry-run output, explicit confirmation, stronger file exclusions, symlink rejection, and fixed batch behavior.
push.js:81Unrestricted Recursive Upload and Symbolic-Link Traversal Can Disclose Local Files
batch.js:62Batch Publisher Executes Import-Time CLI Logic and May Upload the Wrong Directory
The documented purpose understates and misrepresents the actual operational behavior, especially around batch scanning, broad push behavior, and rough change detection. When a skill can publish multiple local skills remotely while claiming a simpler or narrower function, users may authorize actions they did not meaningfully understand, which can lead to accidental data disclosure or unwanted publication.
The lockfile pins js-yaml to version 4.1.1, which is identified by the scanner as affected by multiple denial-of-service issues involving crafted YAML structures that can trigger excessive CPU consumption during parsing. Given this skill explicitly processes skill/package metadata and file format issues, YAML parsing is plausibly part of normal operation, so attacker-controlled input could make the tool hang or consume significant resources.
The package depends on js-yaml 4.1.1, which is flagged with multiple CPU exhaustion/ReDoS-style advisories. Because this skill's purpose includes handling file format issues and likely parsing YAML/skill metadata supplied by users or repositories, a crafted YAML file could trigger excessive CPU consumption and cause denial of service during push or batch processing.
The README explicitly advertises automatic handling of acceptLicenseTerms, which can cause users to submit a legal/contractual acknowledgement they may not have reviewed or intended to accept. In a publishing workflow, silently setting this field reduces informed consent and can create compliance, legal, and trust risks, especially if users assume the tool is only performing formatting fixes.
The README documents discovery of local auth token files and use of Bearer authentication for publishing, but provides no warning that the skill accesses stored credentials and transmits them to a remote registry. In the context of an installable push helper, this increases risk because users may not realize the tool reads sensitive tokens from disk and could expose them through misuse, logging, or unintended publication flows.
The skill describes behavior that uses local environment data and performs network publication, but it does not declare any tool scope or permissions boundary. That makes the trust boundary unclear to users and hosts, increasing the chance of silent token use or unintended remote actions when the skill is invoked.
The usage and feature description omit a clear warning that the skill will read locally stored authentication tokens and send content to a remote registry. This is dangerous because users may run it without realizing it uses existing credentials to perform authenticated publication, which can cause unintentional uploads under their account.
The script reads authentication tokens directly from the user's home-directory config files and then uses them to perform a network publish operation. While this matches the stated purpose of automating publication, accessing credentials from disk without an explicit consent prompt or clear disclosure increases the risk of unintended credential use and silent remote actions under the user's identity.
The skill accesses local credential files without prominently informing the user that it will read authentication material from their home directory. In context, this is tied to the publish workflow rather than obvious malware, but undisclosed credential access is still risky because it normalizes silent token harvesting behavior and can be abused if the endpoint or code changes.
The script recursively uploads nearly the entire skill directory to a remote API, with only a small exclusion list and no interactive confirmation or dry-run summary. This can unintentionally exfiltrate sensitive files included in the directory, such as secrets, local configs, test artifacts, or proprietary data, especially because users may not realize exactly what will be transmitted.
The manifest description and the body of the markdown instructions are presented in Chinese, and there is no indication that users may choose another language or that the skill is intentionally limited to a Chinese-speaking audience. This can violate language/locale policy when a skill forces a specific language without user opt-in.
The manifest description is written entirely in Chinese and presents the skill's behavior in that locale without indicating any language choice or opt-in. Under the policy, language or locale constraints should either offer user choice or be clearly justified as region-specific.
Using a caret range for dependencies allows future installs to resolve to newer package versions without exact reproducibility, which can introduce unexpected behavior or supply-chain risk. In a publishing/push skill that likely processes user-provided files before uploading them, dependency drift can make builds non-deterministic and increase exposure to compromised or breaking releases.
"clawhub-push-batch": "./batch.js"
},
"dependencies": {
"js-yaml": "^4.1.1"
}
}
The file header describes the skill in Chinese only ('一键推送 skill 到 ClawHub registry...') with no indication that users can opt into another language. Under the policy, language or locale constraints should be optional or explicitly justified rather than implicitly imposed.
The code imports execSync from child_process, which is a shell-execution capability unrelated to the stated purpose of pushing skills to the registry. Although it is not used in this file, its presence introduces an unjustified privileged capability relative to the documented intent.